Fix: Typo that does not reload downtimes after retention load #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Shinken 2.4.4 (and exactly since 5f3525f), hosts and services downtimes are lost after arbiter/scheduler restarts.
Shinken 2.4.4 removes the retention of
in_scheduled_downtimeand uses a new method after retention load to re-compute the variable by looking atdowntimeslist. BUT it computesis_in_scheduled_downtimeinstead ofin_scheduled_downtime, so the rest does not work (at least in mod_webui, but I can't see how it could work anywhere).This PR fixes the typo.