Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dense graph solvers are unable to accept upper/lower trianglar matrices. #57

Closed
shinmorino opened this issue Oct 9, 2018 · 3 comments
Closed
Labels
Milestone

Comments

@shinmorino
Copy link
Owner

shinmorino commented Oct 9, 2018

All dense graph solvers are able to deal only with symmetric matrices.
symmetrize() has been added to enable upper/lower triangle matrices, there's a misunderstanding on the equation.

Fix:

  1. Check if a given matrix is symmetric.
    1-1. If symmetric, the matrix will be used as is.
  2. If asymmetric, check if the matrix is upper/lower triangular.
    2-1 If triangular, symmetrize the mat.
  3. Error: Raise exception.

This fix will be applied to all dense graph solvers and functions.

@shinmorino shinmorino added the bug label Oct 9, 2018
@shinmorino shinmorino added this to the Version 1.0 milestone Oct 9, 2018
shinmorino added a commit that referenced this issue Oct 9, 2018
shinmorino added a commit that referenced this issue Oct 9, 2018
@shinmorino
Copy link
Owner Author

Fixes are committed at 45d9005.
Tests have been added.
Py and CPU modules have been tested.

@shinmorino shinmorino changed the title Dense graph solvers are unable to accept upper/lower triangle matrices. Dense graph solvers are unable to accept upper/lower trianglar matrices. Oct 18, 2018
@shinmorino
Copy link
Owner Author

This bug is from beta2.
Before beta2, sqaod is assumed to accept only symmetric matrices, and beta2 is also able to handle symmetric matrices.

@shinmorino
Copy link
Owner Author

Done. 7145fca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant