Allow usage of shinyTree in modules, closes #81

[thothal]

This closes #81.

Dashes were replaced by underscores in the HTML generating function and in the respective JS file, which refers to this. An example was added based on the reprex in #81.

[trafficonese]

I did not spot the difference to #85.

And using your PR I am not seeing the icons rendered correctly. So the problem with #85 persists or am I wrong?

[thothal]

If I run

library(shiny)
runApp(system.file("examples/18-modules", package="shinyTree"))

I get this:

So the icons should be visible. And in #85 you missed to fix the shinyTree.js. So your code did not show any error message any more, because the <script> was now properly set up, but in the JavaScript it still tried to access it via the old name. That's why in your PR the icons worked not via the types argument.

[trafficonese]

All clear, I had not installed your PR at all.

I thought
devtools::install_github('shinyTree/shinyTree', pull=86, ref=NULL)
would do it, but it actually just installed the master branch.
So with
remotes::install_github("shinyTree/shinyTree#86")
I managed to get your PR and indeed the icons show correctly.

Got it, thanks.
So #85 can actully be closed right?

[trafficonese]

You got me quite confused now :)

In #85 there are also changes in the JS file although a bit different than yours, but I think they achieve the same thing.

This is from 85

      var elidtypes = el.id.replace("-", '_');
      if (typeof window[elidtypes + "_sttypes"] !== 'undefined'){
      	sttypes = window[elidtypes + "_sttypes"];
      }

And this is from 86

      if(typeof window[el.id.replace("-", "_") + "_sttypes"] !== 'undefined'){
        sttypes = window[el.id.replace("-", "_") + "_sttypes"];
      }

And running your example with my PR does work aswell. So maybe I had a mistake in the example code?

[thothal]

Hmm, strange, I swear I did not see that in the beginning. That was IMHO the reason why the icons did not show up. But I am pretty new to GitHub so I could very well be that I overlooked something.

So in this case it is exactly the same thing, and maybe the issue was indeed in the example code. In any case, happy that the issue is solved. I will close my PR in this case then. Sorry for the confusion I may have caused.

[trafficonese]

If you dont mind, I would take your example and include it in my PR, so there are 2 different examples of using shinyTree in modules, whereas your example is the way to define types correctly.

I would include you as contributor aswell, then this PR could be closed. You're ok with that?