Added support for UTF-8 clipboard based on TigerVNC/TightVNC extension #27
Conversation
Added support for utf8 clipboard
There was a problem hiding this comment.
Hi @egorksv thanks for this, it looks good in principle. I've had a quick run through and I think this PR includes a lot of changes that are specific to your fork and build environment (POM changes, default passwords etc) - I think you'll need to create a branch in your fork without these changes and open a PR from there. If you get that sorted out I'll have a closer look at the logic and hopefully merge.
| @@ -6,7 +6,7 @@ | |||
| <groupId>com.shinyhut</groupId> | |||
| <artifactId>vernacular</artifactId> | |||
| <packaging>jar</packaging> | |||
| <version>1.15-SNAPSHOT</version> | |||
| <version>1.15.1</version> | |||
| @@ -96,6 +96,7 @@ | |||
| </manifest> | |||
| </archive> | |||
| </configuration> | |||
|
|
|||
| <id>ossrh</id> | ||
| <url>https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/</url> | ||
| <id>maven.nuvalence.repo</id> | ||
| <url>s3://testup-build-artifacts/m2</url> |
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <source>11</source> |
There was a problem hiding this comment.
Undo this - I want to keep this targeting Java 8 for the time being
| @@ -299,9 +300,9 @@ private void addMenu() { | |||
|
|
|||
| private void showConnectDialog() { | |||
| JPanel connectDialog = new JPanel(); | |||
| JTextField hostField = new JTextField(20); | |||
| JTextField hostField = new JTextField("localhost", 20); | |||
| hostField.addAncestorListener(focusRequester); | ||
| JTextField portField = new JTextField("5900"); | ||
| JTextField portField = new JTextField("5901"); |
| @@ -342,9 +343,9 @@ private String showUsernameDialog() { | |||
| } | |||
|
|
|||
| private String showPasswordDialog() { | |||
| String password = ""; | |||
| String password = "headless"; | |||
| JPanel passwordDialog = new JPanel(); | ||
| JPasswordField passwordField = new JPasswordField(20); | ||
| JPasswordField passwordField = new JPasswordField("headless",20); |
| * @return | ||
| * @throws IOException | ||
| */ | ||
| private static ServerCutText readExtendedClipboard(DataInputStream in, int textLength, ClipboardEventHandler handler) throws IOException { |
There was a problem hiding this comment.
This should really have a unit test
| <extensions> | ||
| <extension> | ||
| <groupId>com.github.seahen</groupId> | ||
| <artifactId>maven-s3-wagon</artifactId> |
There was a problem hiding this comment.
Hi Paul
We've encountered a few issues with this feature - just wanted to ensure they're all ironed out before we proceed with the pull request.
Cheers
Egor
No description provided.