Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player physics is off (v0.9.1) #307

Open
denkillen opened this issue Mar 17, 2024 · 4 comments
Open

Player physics is off (v0.9.1) #307

denkillen opened this issue Mar 17, 2024 · 4 comments
Labels
regression Behavior that was in the original game is no longer present or correct

Comments

@denkillen
Copy link

denkillen commented Mar 17, 2024

Various aspects of player physics feel off compared to vanilla:

  • General move speed is slightly slower
  • Swimming is noticeably slower when fighting water currents
  • Jumping has no air control (vanilla had a slight amount in any direction)
  • Jumping against some adjoins causes player to bounce off (see attached)
openjkdf2-adjoinbounce.webm
@shinyquagsire23
Copy link
Owner

shinyquagsire23 commented Mar 17, 2024

Hmm, it's possible some things are still tied to framerate incorrectly. I guess there's a few things to check:

  • General > Advanced > Restore Inconsistent physics
  • General > Advanced > Restore 50Hz midair player physics
  • Test the physics with framerate locked to 50Hz (or higher/lower)

Restore inconsistent physics + messing with framerate will probably be the most interesting, I had to try and adjust framerate to work at high Hz but it definitely was an uphill battle. Currently it works by simulating physics at a constant 150Hz (6x the original nominal 25Hz, which I determined roughly by doing physics tasks on Droidworks maps)

@shinyquagsire23 shinyquagsire23 added the regression Behavior that was in the original game is no longer present or correct label Mar 17, 2024
@denkillen
Copy link
Author

denkillen commented Mar 17, 2024

  • Test the physics with framerate locked to 50Hz (or higher/lower)

I just tested with the framerate locked to 50 and 150 and noticed no differences whatsoever.

@denkillen denkillen changed the title Player physics is off Player physics is off (v0.9.1) Mar 17, 2024
@shinyquagsire23
Copy link
Owner

Oh yeah I edited my comment to explain, lowering FPS without "restore inconsistent physics" won't work since it always simulates 150Hz otherwise.

@denkillen
Copy link
Author

Ah, didn't notice that menu before. I can definitely feel the difference now. I have my FPS set to 75 and it seems to work fine with those settings, other than the obvious mid-air FPS drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Behavior that was in the original game is no longer present or correct
Projects
None yet
Development

No branches or pull requests

2 participants