refactoring

ship-components · Aug 10, 2017 · 1e2dbfd · 1e2dbfd
1 parent 331500f
commit 1e2dbfd
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/Select.js b/src/Select.js
@@ -41,7 +41,7 @@ export default class Select extends React.Component {
   }
 
   componentDidMount() {
-    if (this.props.scrollParentClass) {
+    if (typeof this.props.scrollParentClass === 'string') {
       this.registerScrollParent(this.props.scrollParentClass);
       window.addEventListener('resize', this.handleClose);
     }
@@ -325,7 +325,7 @@ Select.defaultProps = {
   disabled: false,
   value: '',
   options: [],
-  scrollParentClass: false,
+  scrollParentClass: '',
   onChange: void 0
 };
 
@@ -339,10 +339,7 @@ Select.propTypes = {
   icon: PropTypes.element,
   label: PropTypes.string,
   disabled: PropTypes.bool,
-  scrollParentClass: PropTypes.oneOfType([
-    PropTypes.bool,
-    PropTypes.string
-  ]),
+  scrollParentClass: PropTypes.string,
   value: PropTypes.oneOfType([
     PropTypes.string,
     PropTypes.object