Skip to content

Commit

Permalink
Updates gemspec to latest versions (#65)
Browse files Browse the repository at this point in the history
* Updates gemspec to latest versions

* updates hound's rubocop

* updates release version
  • Loading branch information
malachewhiz committed Jun 11, 2019
1 parent 1a4a272 commit 53c8ee6
Show file tree
Hide file tree
Showing 4 changed files with 50 additions and 23 deletions.
3 changes: 2 additions & 1 deletion .hound.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
ruby:
rubocop:
version: 0.68.0
config_file: .rubocop.yml
scss:
enabled: false
Expand Down
61 changes: 43 additions & 18 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
require: rubocop-performance

AllCops:
TargetRubyVersion: 2.5
Exclude:
- vendor/**/*
- db/schema.rb
- bin/*
- config/application.rb
- config/boot.rb
- config/environment.rb

Naming/AccessorMethodName:
Description: Check the naming of accessor methods for get_/set_.
Expand All @@ -23,6 +29,11 @@ Naming/BinaryOperatorParameterName:
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#other-arg'
Enabled: false

Naming/MemoizedInstanceVariableName:
Description: Memoized method name should match memo instance variable name.
Enabled: true
EnforcedStyleForLeadingUnderscores: required

Naming/PredicateName:
Description: 'Check the names of predicate methods.'
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark'
Expand Down Expand Up @@ -129,7 +140,7 @@ Style/EvenOdd:
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#predicate-methods'
Enabled: false

Style/FlipFlop:
Lint/FlipFlop:
Description: 'Checks for flip flops'
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-flip-flops'
Enabled: false
Expand Down Expand Up @@ -166,6 +177,10 @@ Style/InlineComment:
Description: 'Avoid inline comments.'
Enabled: false

Style/IpAddresses:
Description: "Don't include literal IP addresses in code."
Enabled: true

Style/Lambda:
Description: 'Use the new lambda literal syntax for single-line blocks.'
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#lambda-multi-line'
Expand Down Expand Up @@ -258,6 +273,13 @@ Style/RegexpLiteral:
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-r'
Enabled: false

Style/Sample:
Description: >-
Use `sample` instead of `shuffle.first`,
`shuffle.last`, and `shuffle[Fixnum]`.
Reference: 'https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code'
Enabled: false

Style/SelfAssignment:
Description: >-
Checks for places where self-assignment shorthand should have
Expand Down Expand Up @@ -314,8 +336,18 @@ Style/TrailingCommaInArguments:
- no_comma
Enabled: true

Style/TrailingCommaInLiteral:
Description: 'Checks for trailing comma in array and hash literals.'
Style/TrailingCommaInArrayLiteral:
Description: 'Checks for trailing comma in array literals.'
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
EnforcedStyleForMultiline: comma
SupportedStylesForMultiline:
- comma
- consistent_comma
- no_comma
Enabled: true

Style/TrailingCommaInHashLiteral:
Description: 'Checks for trailing comma in hash literals.'
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
EnforcedStyleForMultiline: comma
SupportedStylesForMultiline:
Expand Down Expand Up @@ -365,6 +397,13 @@ Style/OptionHash:

# Layout

Layout/ConditionPosition:
Description: >-
Checks for condition placed in a confusing position relative to
the keyword.
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#same-line-condition'
Enabled: false

Layout/DotPosition:
Description: 'Checks the position of the dot in multi-line method calls.'
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains'
Expand Down Expand Up @@ -440,13 +479,6 @@ Lint/CircularArgumentReference:
Description: "Don't refer to the keyword argument in the default value."
Enabled: true

Lint/ConditionPosition:
Description: >-
Checks for condition placed in a confusing position relative to
the keyword.
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#same-line-condition'
Enabled: false

Lint/DeprecatedClassMethods:
Description: 'Check for deprecated class method calls.'
Enabled: false
Expand Down Expand Up @@ -513,7 +545,7 @@ Lint/UnderscorePrefixedVariableName:
Description: 'Do not use prefix `_` for a variable that is used.'
Enabled: false

Lint/UnneededDisable:
Lint/UnneededCopDisableDirective:
Description: >-
Checks for rubocop:disable comments that can be removed.
Note: this cop is not disabled when disabling all cops.
Expand Down Expand Up @@ -608,13 +640,6 @@ Performance/ReverseEach:
Reference: 'https://github.com/JuanitoFatas/fast-ruby#enumerablereverseeach-vs-enumerablereverse_each-code'
Enabled: false

Performance/Sample:
Description: >-
Use `sample` instead of `shuffle.first`,
`shuffle.last`, and `shuffle[Fixnum]`.
Reference: 'https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code'
Enabled: false

Performance/Size:
Description: >-
Use `size` instead of `count` for counting
Expand Down
2 changes: 1 addition & 1 deletion lib/pactas_itero/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module PactasItero
VERSION = "0.4.0".freeze
VERSION = "0.5.0".freeze
end
7 changes: 4 additions & 3 deletions pactas_itero.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,14 @@ Gem::Specification.new do |spec|

spec.required_ruby_version = ">= 2.0"

spec.add_dependency("faraday_middleware", ">= 0.9.1", "< 0.12")
spec.add_dependency("rash")
spec.add_dependency("faraday_middleware", "~> 0.13")
spec.add_dependency("rash_alt", "~> 0.4")

spec.add_development_dependency 'bundler'
spec.add_development_dependency 'rake'
spec.add_development_dependency "rspec", '~> 3.8.0'
spec.add_development_dependency("rubocop", '~> 0.52.1') # check houndci compatibility before updating rubocop
spec.add_development_dependency("rubocop", '~> 0.68') # check houndci compatibility before updating rubocop
spec.add_development_dependency("rubocop-performance", "~> 1.3")
spec.add_development_dependency("simplecov", "~> 0.16.1")
spec.add_development_dependency("webmock", "~> 3.3")
end

0 comments on commit 53c8ee6

Please sign in to comment.