Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop to version 1.48.1 #138

Closed
wants to merge 1 commit into from
Closed

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 16, 2023

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.25.1 → ~> 1.48.1) · Repo · Changelog

Release Notes

1.48.1

Bug fixes

  • #11673: Fix incorrect Style/HashSyntax autocorrection for assignment methods. (@gsamokovarov)
  • #11682: Fix a false positive for Lint/UselessRescue when using Thread#raise in rescue clause. (@koic)
  • #11672: Fix an error for Layout/BlockEndNewline when multiline block } is not on its own line and it is used as multiple arguments. (@koic)
  • #11675: Style/AccessorGrouping: Fix sibling detection for methods with type sigs. (@issyl0)
  • #11658: Fix Lint/Debugger should not allow pry. (@ThHareau)
  • #11686: Fix Lint/Syntax behavior when Enabled: false of Lint department. (@koic)
  • #11677: Fix the severity for Lint/Syntax. (@koic)
  • #11691: Fix an error for Gemspec/DependencyVersion when method called on gem name argument for add_dependency. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 21 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Mar 16, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 16, 2023

Code Climate has analyzed commit 8592b06 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.1% (0.0% change).

View more on Code Climate.

@depfu
Copy link
Contributor Author

depfu bot commented Apr 10, 2023

Closed in favor of #139.

@depfu depfu bot closed this Apr 10, 2023
@depfu depfu bot deleted the depfu/update/rubocop-1.48.1 branch April 10, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants