Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop to version 0.62.0 #51

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jan 2, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.52.1 → ~> 0.62.0) · Repo · Changelog

Release Notes

0.62.0

New features

  • #6580: New cop Rails/LinkToBlank checks for link_to calls with target: '_blank' and no rel: 'noopener'. (@Intrepidd)

Bug fixes

  • #6560: Consider file count, not offense count, for --exclude-limit in combination with --auto-gen-only-exclude. (@jonas054)
  • #4229: Fix unexpected Style/HashSyntax consistency offence. (@timon)
  • #6500: Add offense to use in_time_zone instead of deprecated to_time_in_current_zone. (@nadiyaka)
  • #6577: Prevent Rails/Blank cop from adding offense when define the blank method. (@jonatas)
  • #6554: Prevent Layout/RescueEnsureAlignment cop from breaking on block assignment when assignment is on a separate line. (@timmcanty)
  • #6343: Optimise --auto-gen-config when Metrics/LineLength cop is disabled. (@tom-lord)
  • #6389: Fix false negative for Style/TrailingCommaInHashLiteral/Style/TrailingCommaInArrayLiteral when there is a comment in the last line. (@bayandin)
  • #6566: Fix false positive for Layout/EmptyLinesAroundAccessModifier when at the end of specifying a superclass is missing blank line. (@koic)
  • #6571: Fix a false positive for Layout/TrailingCommaInArguments when a line break before a method call and EnforcedStyleForMultiline is set to consistent_comma. (@koic)
  • #6573: Make Layout/AccessModifierIndentation work for dynamic module or class definitions. (@deivid-rodriguez)
  • #6562: Fix a false positive for Style/MethodCallWithArgsParentheses omit_parentheses enforced style after safe navigation call. (@gsamokovarov)
  • #6570: Fix a false positive for Style/MethodCallWithArgsParentheses omit_parentheses enforced style while splatting the result of a method invocation. (@gsamokovarov)
  • #6598: Fix a false positive for Style/MethodCallWithArgsParentheses omit_parentheses enforced style for calls with regexp slash literals argument. (@gsamokovarov)
  • #6598: Fix a false positive for Style/MethodCallWithArgsParentheses omit_parentheses enforced style for default argument value calls. (@gsamokovarov)
  • #6598: Fix a false positive for Style/MethodCallWithArgsParentheses omit_parentheses enforced style for argument calls with braced blocks. (@gsamokovarov)
  • #6594: Fix a false positive for Rails/OutputSafety when the receiver is a non-interpolated string literal. (@amatsuda)
  • #6574: Fix Style/AccessModifierIndentation not handling arbitrary blocks. (@deivid-rodriguez)
  • #6370: Fix the enforcing style from extend self into module_function when there are private methods. (@Ruffeng)

Changes

  • #595: Exclude files ignored by git. (@AlexWayfer)
  • #6429: Fix autocorrect in Rails/Validation to not wrap hash options with braces in an extra set of braces. (@bquorning)
  • #6533: Improved warning message for unrecognized cop parameters to include Supported parameters. (@MagedMilad)
Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jan 2, 2019
@depfu depfu bot mentioned this pull request Jan 2, 2019
@depfu
Copy link
Contributor Author

depfu bot commented Jan 17, 2019

Closed in favor of #52.

1 similar comment
@depfu
Copy link
Contributor Author

depfu bot commented Jan 17, 2019

Closed in favor of #52.

@depfu depfu bot closed this Jan 17, 2019
@depfu depfu bot deleted the depfu/update/rubocop-0.62.0 branch January 17, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants