Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop to version 1.15.0 #92

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 24, 2021

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.68 → ~> 1.15) · Repo · Changelog

Release Notes

1.15.0

New features

Bug fixes

  • #9749: Fix autocorrection for Layout/LineLength to not move the first argument of an unparenthesized send node to the next line, which changes behaviour. (@dvandersluis)
  • #9799: Fix invalid line splitting by Layout/LineLength for send nodes with heredoc arguments. (@dvandersluis)
  • #9773: Fix Style/EmptyLiteral to not register offenses for String.new when Style/FrozenStringLiteral is enabled. (@dvandersluis)
  • #9771: Change AllowDSLWriters to true by default for Style/TrivialAccessors. (@koic)
  • #9777: Fix an incorrect auto-correct for Style/RedundantBegin when using multi-line if in begin block. (@koic)
  • #9791: Fix a false negative for Layout/IndentationWidth when using ensure in do ... end block. (@koic)
  • #9766: Fix a clobbering error for Style/ClassAndModuleChildren cop with compact style. (@tejasbubane)
  • #9767: Fix Style/ClassAndModuleChildren cop to preserve comments. (@tejasbubane)
  • #9792: Fix false positive for Lint/Void cop with ranges. (@tejasbubane)

Changes

  • #9770: Update Lint/EmptyBlock to handle procs the same way as lambdas. (@dvandersluis)
  • #9776: Update Style/NilLambda to handle procs as well. (@dvandersluis)
  • #9744: The parallel flag will now be automatically ignored when combined with --cache false. Previously, an error was raised and execution stopped. (@rrosenblum)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 37 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 24, 2021
@depfu depfu bot mentioned this pull request May 24, 2021
@depfu
Copy link
Contributor Author

depfu bot commented Jun 22, 2021

Closed in favor of #93.

@depfu depfu bot closed this Jun 22, 2021
@depfu depfu bot deleted the depfu/update/rubocop-1.15.0 branch June 22, 2021 11:10
@depfu
Copy link
Contributor Author

depfu bot commented Jun 22, 2021

Closed in favor of #93.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants