add services attribute to carriers call #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,22 +43,54 @@ | |||
| stub_carriers_request | |||
| allow(Shipcloud::Carrier).to receive(:new) | |||
|
|
|||
| carriers = Shipcloud::Carrier.all | |||
| _carriers = Shipcloud::Carrier.all | |||
There was a problem hiding this comment.
Seems we don't need the assignment? I would suggest to remove it.
|
only one (minor) suggestions |
andrecedik
force-pushed
the
ac-add-services-attribute-to-carriers-call
branch
from
1680fb5
to
3ca307e
Compare
andrecedik
added a commit
that referenced
this pull request
Oct 26, 2015
…riers-call add services attribute to carriers call
sfroehler
added a commit
that referenced
this pull request
Jan 21, 2016
- This CHANGELOG file (Following "[Keep a CHANGELOG](http://keepachangelog.com/)") - Create, find, update and index operations for address resource. (#4) - Services attribute to carriers call (#5) - Index operation for shipment resources with optional filter parameters. (#6) - Create, find and index operations for webhook resource. (#7) - Added the following ruby versions to travis-ci test runs: - 2.1.7 - 2.2.4 - 2.3.0 - Add ShipmentQuotes class returning the price for a certain shipment (#9) - Dropped support for ruby 1.9.x in order to use the new language features of ruby 2.x. The official support of ruby 1.9.3 already ended on February 23, 2015 (https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/) - Removed the following ruby versions from travis-ci test runs: - 2.1.5 - 2.2.1 - 2.2.2 - 2.2.3 - Start following [SemVer](http://semver.org) properly. - The link to the developer documenation for the Shipment ressource still pointed at Apiary; it now correctly points to the shipcloud Developer Portal's API section on Shipments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling of services to the carriers call