RequirePreviousExceptionPassRule - rename strict mode parameter to re…

…portEvenIfExceptionIsNotAcceptableByRethrownOne (#13)

README.md

@@ -192,7 +192,7 @@ function validate(): void {
 ```neon
 rules:
     - ShipMonk\PHPStan\Rule\RequirePreviousExceptionPassRule(
-        checkRethrownExceptionAcceptsCaughtOne: true
+        reportEvenIfExceptionIsNotAcceptableByRethrownOne: false
     )
 ```
 ```php
@@ -203,7 +203,7 @@ try {
 }
 ```
 
-- If you want to be even stricter, you can set up `checkRethrownExceptionAcceptsCaughtOne` to `false` and the rule will start reporting even cases where the thrown exception does not have parameter matching the caught exception
+- If you want to be even stricter, you can set up `reportEvenIfExceptionIsNotAcceptableByRethrownOne` to `true` and the rule will start reporting even cases where the thrown exception does not have parameter matching the caught exception
   - That will force you to add the parameter to be able to pass it as previous
   - Usable only if you do not throw exceptions from libraries, which is a good practice anyway
 

src/Rule/RequirePreviousExceptionPassRule.php

@@ -37,12 +37,12 @@ class RequirePreviousExceptionPassRule implements Rule
 
     private Standard $printer;
 
-    private bool $checkRethrownExceptionAcceptsCaughtOne;
+    private bool $reportEvenIfExceptionIsNotAcceptableByRethrownOne;
 
-    public function __construct(Standard $printer, bool $checkRethrownExceptionAcceptsCaughtOne = true)
+    public function __construct(Standard $printer, bool $reportEvenIfExceptionIsNotAcceptableByRethrownOne = false)
     {
         $this->printer = $printer;
-        $this->checkRethrownExceptionAcceptsCaughtOne = $checkRethrownExceptionAcceptsCaughtOne;
+        $this->reportEvenIfExceptionIsNotAcceptableByRethrownOne = $reportEvenIfExceptionIsNotAcceptableByRethrownOne;
     }
 
     public function getNodeType(): string
@@ -121,7 +121,7 @@ private function processExceptionCreation(bool $strictTypes, ?string $caughtExce
             }
         }
 
-        if ($this->checkRethrownExceptionAcceptsCaughtOne) {
+        if (!$this->reportEvenIfExceptionIsNotAcceptableByRethrownOne) {
             $accepts = false;
 
             foreach ($this->getCallLikeParameters($node, $scope) as $parameter) {

tests/Rule/RequirePreviousExceptionPassRuleTest.php

@@ -13,29 +13,29 @@
 class RequirePreviousExceptionPassRuleTest extends RuleTestCase
 {
 
-    private ?bool $checkRethrownExceptionAcceptsCaughtOne = null;
+    private ?bool $reportEvenIfExceptionIsNotAcceptableByRethrownOne = null;
 
     protected function getRule(): Rule
     {
-        if ($this->checkRethrownExceptionAcceptsCaughtOne === null) {
+        if ($this->reportEvenIfExceptionIsNotAcceptableByRethrownOne === null) {
             throw new LogicException('Testcase need to initialize this');
         }
 
         return new RequirePreviousExceptionPassRule(
             self::getContainer()->getByType(Standard::class),
-            $this->checkRethrownExceptionAcceptsCaughtOne,
+            $this->reportEvenIfExceptionIsNotAcceptableByRethrownOne,
         );
     }
 
     public function testWithAcceptCheck(): void
     {
-        $this->checkRethrownExceptionAcceptsCaughtOne = true;
+        $this->reportEvenIfExceptionIsNotAcceptableByRethrownOne = false;
         $this->analyseFile(__DIR__ . '/data/RequirePreviousExceptionPassRule/with-accept-check.php');
     }
 
     public function testWithoutAcceptCheck(): void
     {
-        $this->checkRethrownExceptionAcceptsCaughtOne = false;
+        $this->reportEvenIfExceptionIsNotAcceptableByRethrownOne = true;
         $this->analyseFile(__DIR__ . '/data/RequirePreviousExceptionPassRule/without-accept-check.php');
     }