ForbidUnusedMatchResultRule: support nested matches (#106)

shipmonk-rnd · Apr 21, 2023 · bdae03f · bdae03f
1 parent 25f397a
commit bdae03f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Visitor/UnusedMatchVisitor.php b/src/Visitor/UnusedMatchVisitor.php
@@ -14,6 +14,7 @@
 use PhpParser\Node\Expr\Throw_ as ThrowExpr;
 use PhpParser\Node\Expr\Yield_;
 use PhpParser\Node\Expr\YieldFrom;
+use PhpParser\Node\MatchArm;
 use PhpParser\Node\Stmt\Return_;
 use PhpParser\Node\Stmt\Throw_;
 use PhpParser\NodeVisitorAbstract;
@@ -82,6 +83,7 @@ private function isUsed(Node $parent): bool
             || $parent instanceof ArrayItem
             || $parent instanceof NullsafeMethodCall
             || $parent instanceof Ternary
+            || $parent instanceof MatchArm
             || $parent instanceof Yield_
             || $parent instanceof YieldFrom
             || $parent instanceof ThrowExpr;

diff --git a/tests/Rule/data/ForbidUnusedMatchResultRule/code.php b/tests/Rule/data/ForbidUnusedMatchResultRule/code.php
@@ -24,6 +24,15 @@ public function testUsed(bool $bool): mixed
             true => "Bar",
         } ?? null;
 
+        $a = match ($int) {
+            0 => $a = '0',
+            1 => $b = '1',
+            default => match ($bool) {
+                false => "2",
+                true => "3",
+            },
+        };
+
         $this->use(match ($bool) {
             false => new LogicException(),
             true => new RuntimeException(),