20.4.2 MNB-2576 Rolled back MNB-2405

shipperhq · Jun 1, 2022 · 15e50a9 · 15e50a9
1 parent abd832c
commit 15e50a9
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 29 deletions.
diff --git a/CHANGELOG-PUBLIC.md b/CHANGELOG-PUBLIC.md
@@ -48,3 +48,7 @@ MND-2430 M2.4.4 compatibility
 MNB-2542 Change version requirements for laminas-dependency-plugin
 
 
+## 20.4.2 (2022-06-01)
+MNB-2576 Rolled back MNB-2405
+
+
diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -48,3 +48,7 @@ MND-2430 M2.4.4 compatibility
 MNB-2542 Change version requirements for laminas-dependency-plugin
 
 
+## 20.4.2 (2022-06-01)
+MNB-2576 Rolled back MNB-2405
+
+
diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "shipperhq/library-graphql",
     "description": "ShipperHQ GraphQL Library",
     "type": "magento2-library",
-    "version": "20.4.1",
+    "version": "20.4.2",
     "license": [
         "OSL-3.0",
         "AFL-3.0"

diff --git a/src/Types/Input/RMSItem.php b/src/Types/Input/RMSItem.php
@@ -39,11 +39,6 @@ class RMSItem
      */
     private $sku;
 
-    /**
-     * @var string
-     */
-    private $name;
-
     /**
      * @var float
      */
@@ -133,7 +128,6 @@ class RMSItem
      * RMSItem constructor.
      * @param string $itemId
      * @param string $sku
-     * @param string $name
      * @param float $storePrice
      * @param float $weight
      * @param int $qty
@@ -153,11 +147,10 @@ class RMSItem
      * @param RMSItem[] $items
      * @throws SerializerException
      */
-    public function __construct($itemId, $sku, $name, $storePrice, $weight, $qty, $type, $taxInclStorePrice, $freeShipping, $fixedPrice, $fixedWeight, $basePrice = null, $taxInclBasePrice = null, $discountPercent = null, $discountedBasePrice = null, $discountedStorePrice = null, $discountedTaxInclBasePrice = null, $discountedTaxInclStorePrice = null, array $attributes = null, array $items = null)
+    public function __construct($itemId, $sku, $storePrice, $weight, $qty, $type, $taxInclStorePrice, $freeShipping, $fixedPrice, $fixedWeight, $basePrice = null, $taxInclBasePrice = null, $discountPercent = null, $discountedBasePrice = null, $discountedStorePrice = null, $discountedTaxInclBasePrice = null, $discountedTaxInclStorePrice = null, array $attributes = null, array $items = null)
     {
         $this->setItemId($itemId)
             ->setSku($sku)
-            ->setName($name)
             ->setStorePrice($storePrice)
             ->setWeight($weight)
             ->setQty($qty)
@@ -213,24 +206,6 @@ public function setSku($sku)
         return $this;
     }
 
-    /**
-     * @return string
-     */
-    public function getName()
-    {
-        return $this->name;
-    }
-
-    /**
-     * @param string $name
-     * @return RMSItem
-     */
-    public function setName($name)
-    {
-        $this->name = $name;
-        return $this;
-    }
-
     /**
      * @return float
      */
@@ -300,7 +275,7 @@ public function getType()
      */
     public function setType($type)
     {
-        $type = strtoupper((string) $type);
+        $type = strtoupper($type);
 
         if (in_array($type, self::AVAILABLE_ITEM_TYPES)) {
             $this->type = $type;
@@ -553,4 +528,4 @@ public function setItems($items)
         $this->items = $items;
         return $this;
     }
-}
+}