Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for FastBoot 1.0. #182

Merged

Conversation

kratiahuja
Copy link
Contributor

This should make the addon compatible to fastboot 1.0 mentioned in ember-fastboot/ember-cli-fastboot#387

@rwwagner90 I don't know how this addon is supposed to work. So I haven't tested this addon with and without fastboot addon. Please make sure to test to test it before merging.

@RobbieTheWagner
Copy link
Owner

@kratiahuja thanks for the PR! ember-cli-node-assets only works with the key of the node module name, so flatpickrJs and flatpickrCss does not work. I assume the only necessary piece here is this?

processTree(input) {
  return fastbootTransform(input);
}

@RobbieTheWagner RobbieTheWagner merged commit 42c9585 into RobbieTheWagner:master Jun 19, 2017
@kratiahuja
Copy link
Contributor Author

@rwwagner90 Yes that is correct. The only important piece is processTree. You don't need to wrap the css with that check, hence I wanted to split it. Curious, if this doesn't work, why is it merged?

@RobbieTheWagner
Copy link
Owner

@kratiahuja I pulled your PR down, made a new branch to play with it, and eventually merged that branch, mostly to make sure you got credit for your contributions 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants