Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Explosive Decompression #446

Closed
AtlasRules opened this issue Nov 18, 2021 · 2 comments
Closed

[BUG] Explosive Decompression #446

AtlasRules opened this issue Nov 18, 2021 · 2 comments
Labels
Bug Something isn't working

Comments

@AtlasRules
Copy link
Contributor

AtlasRules commented Nov 18, 2021

Round ID:

391, 392, and 393

Testmerges:

#230: '[TEMP] Disable loadout costs' by AsciiSquid at commit a7399a3
#218: 'Swifter's Ship Emporium!' by swifterjack at commit 02b52b5
#405: 'Readds Rapid Shuttle Designator' by MarkSuckerberg at commit b85413f
#132: 'Readds Explosive Decompression' by MarkSuckerberg at commit 7e07d7c (this one)
#313: 'Overmap Expansion #2' by retlaw34 at commit 6dd6e32
#425: 'resprites the charcoal, navy, and burghundy suits, splits them into suit and jacket combos' by triplezeta at commit 9094943
#438: 'Sound improvements' by CapnMachaddish at commit 2bdbc70
#436: 'Revamps Cryo Consoles' by MarkSuckerberg at commit 48ba3ad
#437: 'Adds Table Bells' by triplezeta at commit 8c4eff0
#403: 'Adds Quirk specie-locks, vampire quirk.' by Ms-Mee at commit 5816274

Reproduction:

  1. Have explosive decomp merged.
  2. Wait for the crash.
  3. While waiting, observe the infinite whirlwinds, things freezing that should not free (e.g, shutters, solars), and other strange phenomena.
  4. Have the server crash and lose your shipcoins.
@AtlasRules AtlasRules added the Bug Something isn't working label Nov 18, 2021
@terg-but-ius
Copy link
Contributor

terg-but-ius commented Nov 18, 2021

explosive decomp has had a history of being fucky, it seems the issues were not wholly fixed
can say that what atlas has pointed out is true

@MarkSuckerberg
Copy link
Member

Thank you very very much for the feedback, but I'll be moving it to the PR itself.

SuhEugene pushed a commit to SuhEugene/Shiptest that referenced this issue Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants