Cleanup of Shuttle Subsystem + General Housekeeping [MDB IGNORE] #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Admin
ZephyrTFA
added
Red Label
ZephyrTFA
previously requested changes
Sep 3, 2021
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
MarkSuckerberg
force-pushed
the
proper-endround
branch
from
f34b7db
to
5f8caac
Compare
github-actions
bot
added
the
Config
MarkSuckerberg
changed the title
|
Updated changelog and PR description to better show all the changes this PR makes. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ZephyrTFA
approved these changes
Sep 7, 2021
|
Conflicts with #108, waiting for that to be merged before this can get TM'd |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MarkSuckerberg
changed the title
MarkSuckerberg
force-pushed
the
proper-endround
branch
from
390baea
to
ae9c8a7
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Basically removes everything in the code related to the Emergency shuttle, as well as cleans up SSshuttle in general. I don't doubt this will break things so it should be tested thoroughly.
Also removes most non-shiptest shuttle map files and datums, as most are too small to even be considered for repurposing as a normal ship.
Most of the more trivial (relatively) changes are listed in the changelog.
Why It's Good For The Game
The emergency shuttle is unused and breaks certain things because it doesn't ever exist.
Changelog
🆑
admin: The call-shuttle and cancel-shuttle verbs have been replaced with initiate_jump and cancel_jump respectively.
admin: You can actually open check-antagonists again to delay the round \o/
del: Emergency shuttle code
del: Personal objectives. I am quite sure this was broken already anyways.
del: Lots of unrelated shuttle map files and templates.
del: A lot of antagonist objective code has been removed (as it didn't work at all already)
del: AIs can no longer randomly initiate a shuttle call
del: Normal cargo shuttle consoles have been removed, as they do not work. Express consoles remain.
del: The old and deprecated shuttle consoles have been removed as they do not work.
del: Bluespace gigabeacons have been removed since they do not work.
del: Emergency shuttle purchasing has been removed. Not that it worked at all anyways.
del: Removed unbuyable shuttle config for obvious reasons seen in the entry above.
tweak: Express cargo consoles no longer require you to unlock them.
tweak: Express cargo consoles' "cargo bay" option will now actually send pods to your current ship's cargo bay.
tweak: Export scanners no longer need to be "linked" to a cargo shuttle console.
tweak: Moved whiteship map files into the shiptest directory as they're normal ships now.
/:cl: