Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes rock sprites ingame [WHOOPS] #2332

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

Zevotech
Copy link
Contributor

@Zevotech Zevotech commented Sep 3, 2023

About The Pull Request

Rocks were invisible in game due to a recently merged PR of mine. this is why we testmerge PRs! anyways this should fix them.

Adds flora and rock missing texture sprites to most flora files to prevent something like this from ever happening again.

Why It's Good For The Game

invisible things that block movement bad yeah. i want to fix my mistakes.

Changelog

馃啈
fix: Most rocks are now visible again
add: Most flora files now have missing texture sprites to make it easier to spot when something has gone wrong.
/:cl:

@Zevotech Zevotech requested review from a team as code owners September 3, 2023 05:21
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Sep 3, 2023
@github-actions github-actions bot removed the Map Change Tile placing is hard. Thank you for your service. label Sep 3, 2023
@Zevotech
Copy link
Contributor Author

Zevotech commented Sep 4, 2023

馃ズ

Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this breaks

@Zevotech
Copy link
Contributor Author

Zevotech commented Sep 4, 2023

if it breaks its partially your fault bestie

@Zevotech
Copy link
Contributor Author

Zevotech commented Sep 4, 2023

but it shouldnt. right. right. right. right. right.

@rye-rice
Copy link
Member

rye-rice commented Sep 5, 2023

ill hold you to your word

@rye-rice rye-rice added this pull request to the merge queue Sep 5, 2023
Merged via the queue into shiptest-ss13:master with commit b22529f Sep 5, 2023
10 checks passed
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Rocks were invisible in game due to a recently merged PR of mine. this
is why we testmerge PRs! anyways this should fix them.

Adds flora and rock missing texture sprites to most flora files to
prevent something like this from ever happening again.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
invisible things that block movement bad yeah. i want to fix my
mistakes.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: Most rocks are now visible again
add: Most flora files now have missing texture sprites to make it easier
to spot when something has gone wrong.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants