Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BETA API] Add Beta APIs #1103

Closed
SaschaSchwarze0 opened this issue Sep 2, 2022 · 3 comments · Fixed by #1235
Closed

[BETA API] Add Beta APIs #1103

SaschaSchwarze0 opened this issue Sep 2, 2022 · 3 comments · Fixed by #1235
Assignees
@qu1queee
Labels
beta BETA related issue kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Milestone
release-v0.12.0

Comments

@SaschaSchwarze0
Copy link
Member

Add v1beta1 Go types to https://github.com/shipwright-io/build/tree/main/pkg/apis/build.

Make sure that clientsets are there: https://github.com/shipwright-io/build/tree/main/pkg/client/clientset

The controller will stay on v1alpha1. Also, the stored version will still be v1alpha1.
@SaschaSchwarze0 SaschaSchwarze0 added kind/feature Categorizes issue or PR as related to a new feature. beta BETA related issue kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Sep 2, 2022
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Sep 2, 2022
@adambkaplan adambkaplan mentioned this issue Oct 14, 2022
Closed
@liangyuanpeng
Copy link

liangyuanpeng commented Mar 10, 2023 •
edited

The controller will stay on v1alpha1. Also, the stored version will still be v1alpha1.

Is it mean this issue just want to add v1beta1 types and the controller is not working for v1beta1 today? @SaschaSchwarze0

@SaschaSchwarze0
Copy link
Member Author

The controller will stay on v1alpha1. Also, the stored version will still be v1alpha1.

Is it mean this issue just want to add v1beta1 types and the controller is not working for v1beta1 today? @SaschaSchwarze0

This issue is about adding the v1beta1 APIs. This won't make them functional. They will become functional by the conversion webhook. And then eventually, the controller will switch to v1beta1.

@liangyuanpeng liangyuanpeng mentioned this issue Mar 10, 2023
Closed
4 tasks
@liangyuanpeng
Copy link

liangyuanpeng commented Mar 10, 2023 •
edited

Your prompt reply is good for me !! i create a PR for this issue,Thanks.

@qu1queee qu1queee self-assigned this Mar 10, 2023
@qu1queee qu1queee mentioned this issue Mar 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qu1queee qu1queee

Labels
beta BETA related issue kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
release-v0.12.0
Development

Successfully merging a pull request may close this issue.

Add v1beta1 types qu1queee/build
Add v1beta1 api types liangyuanpeng/shipwright-build
3 participants
@qu1queee @liangyuanpeng @SaschaSchwarze0