Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1beta1 types #1235

Merged
merged 6 commits into from May 4, 2023
Merged

Add v1beta1 types #1235

merged 6 commits into from May 4, 2023

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Mar 13, 2023 •
edited

Changes

Fixes #1103

This work is based on shipwright-io/community#105 and https://hackmd.io/BsPjvGFwQgmVeJRe6FJfMA#Build-sources

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

API additions: Introduce Shipwright Build v1beta1 API types

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Label for when a PR has specified a release note labels Mar 13, 2023
@qu1queee qu1queee removed the release-note Label for when a PR has specified a release note label Mar 13, 2023
@qu1queee qu1queee force-pushed the qu1queee/apis_beta branch 4 times, most recently from 565f149 to b264e31 Compare March 28, 2023 06:28
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Apr 3, 2023
@qu1queee qu1queee force-pushed the qu1queee/apis_beta branch 2 times, most recently from c8fd656 to c2487f8 Compare April 7, 2023 14:22
@qu1queee qu1queee marked this pull request as ready for review April 7, 2023 14:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2023
@qu1queee qu1queee removed the request for review from adambkaplan April 7, 2023 14:33
SaschaSchwarze0
SaschaSchwarze0 requested changes Apr 13, 2023
View reviewed changes
docs/buildstrategies.md Outdated Show resolved Hide resolved
pkg/apis/build/v1beta1/build_types.go Outdated

// BuildSpec defines the desired state of Build
type BuildSpec struct {
// Source refers to the Git repository containing the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source is more than Git.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited.

pkg/apis/build/v1beta1/build_types.go
ParamValues []ParamValue `json:"paramValues,omitempty"`

// Output refers to the location where the built image would be pushed.
Output Image `json:"output"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo the type should be named Output like the key, that would be consistent with what we do anywhere else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, however I prefer this to be a separated item via its own issue.

pkg/apis/build/v1beta1/build_types.go Show resolved Hide resolved
pkg/apis/build/v1beta1/buildrun_types.go Outdated Show resolved Hide resolved
pkg/apis/build/v1beta1/buildstrategy.go Outdated Show resolved Hide resolved
pkg/apis/build/v1beta1/source.go Outdated Show resolved Hide resolved
pkg/apis/build/v1beta1/source.go Show resolved Hide resolved
pkg/apis/build/v1beta1/source.go Outdated Show resolved Hide resolved
pkg/apis/build/v1beta1/trigger.go Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2023
@qu1queee
add build v1beta1 api types
3a6e71f
@qu1queee
Add support v1beta1
b9cd9c4 
- Set storage version to v1alpha API types
- Extend code generation script to support v1beta1 API type
@qu1queee
generate files for v1beta1
a41f92b
@qu1queee
Use --server-side flag for kubectl apply
44d85f9 
We exceeded the metadata.annotations size(over 262144 bytes), with the
new types aggregation. Using --server-side flag ensures the
last-applied-configuration annotation is not counted.
@qu1queee @SaschaSchwarze0
More API changes for v1beta1
9a65bd2 
- Fixes on existing API fields
- Modifications on existing API fields
- Removals of unwanted or unnecessary API fields

Coming from a pull request review.

Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
@qu1queee
Regenerate crds and deepcopy artifacts
dfbab16 
Applies new changes on the v1beta1 API fields
@qu1queee
Copy link
Contributor Author

qu1queee commented May 1, 2023

@SaschaSchwarze0 pls re-review, thanks a lot for the first review.

SaschaSchwarze0
SaschaSchwarze0 approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

Adding hold for the ship to be merged first. But looks all good to me.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@SaschaSchwarze0 SaschaSchwarze0 added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 3, 2023
@SaschaSchwarze0
Copy link
Member

Ship is merged.

/unhold
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone May 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit a72c420 into shipwright-io:main May 4, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.

[BETA API] Add Beta APIs
3 participants
@qu1queee @SaschaSchwarze0 @openshift-merge-robot