Modernize Buildah sample build strategy #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
added
the
kind/feature
gabemontero
approved these changes
Feb 7, 2022
| @@ -17,49 +17,158 @@ spec: | |||
| - | | |||
| set -euo pipefail | |||
|
|
|||
| echo "Creating registries config file..." | |||
| # Parse parameters | |||
There was a problem hiding this comment.
not asking as part of this PR, but I'm curious what would happen if you extracted the bash from this file, put it in a .sh file, and ran shellcheck against it
There was a problem hiding this comment.
I had to do this because it failed as I had too much "s at one place. :-) But yeah, I further extended it after this. Would somehow be nice to get the inline script validated.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I am changing the recently added registry configuration related parameters to arrays. I am adding build-arg support. I am using registries-insecure to also define whether tlsVerify on push should be set to false. And I am writing error details when the context dir or the Dockerfile do not exist.
Fixes #988
Submitter Checklist
Release Notes