Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom error for basic auth with HTTP #1176

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Add custom error for basic auth with HTTP #1176

merged 5 commits into from
Jan 5, 2023

Commits on Jan 4, 2023

  1. Refactor username/password test cases 

    Change test cases for username and password to use same function style.
    @HeavyWombat
    HeavyWombat committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    c61a690 View commit details
    Browse the repository at this point in the history

  2. Fix linter warnings 

    Fix linter warning by renaing variable or inlining them.
    @HeavyWombat
    HeavyWombat committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    ed5f8d9 View commit details
    Browse the repository at this point in the history

  3. Add custom error for basic auth with HTTP 

    Fixes: #1131

Ref: #1116

Check that basic auth is not used in combination with a HTTP endpoint.
    @HeavyWombat
    HeavyWombat committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    46ae1d4 View commit details
    Browse the repository at this point in the history

  4. Redact incline credentials in log 

    Introduce display URL that is a safe version of the provided URL to be
used for logging.

Refactor test case code in order to allow for more flexibility.
    @HeavyWombat
    HeavyWombat committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    bfce81e View commit details
    Browse the repository at this point in the history

  5. Do not dump SSH key to output 

    Do not write the SSH key in the test output.
    @HeavyWombat
    HeavyWombat committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    11ff2da View commit details
    Browse the repository at this point in the history