Use --snapshot-mode instead of --snapshotMode and --tar-path instead --tarPath in sample build strategies that use Kaniko #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
added
the
kind/cleanup
pull-request-size
bot
added
the
size/S
openshift-ci
bot
added
the
release-note
SaschaSchwarze0
changed the title
coreydaley
suggested changes
Aug 21, 2023
samples/buildstrategy/kaniko/buildstrategy_kaniko-trivy_cr.yaml
Outdated
Show resolved
Hide resolved
samples/buildstrategy/source-to-image/buildstrategy_source-to-image_cr.yaml
Outdated
Show resolved
Hide resolved
qu1queee
approved these changes
Aug 22, 2023
SaschaSchwarze0
force-pushed
the
sascha-kaniko-flag
branch
from
14e76d7
to
9364f80
Compare
|
/lgtm |
coreydaley
approved these changes
Aug 23, 2023
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coreydaley, SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Already last year, Kaniko cleaned up command line flags to make naming consistent. The
snapshotModeandtarPathare deprecated and cause a warning. Adopting our strategy example to usesnapshot-modeandtar-path.Submitter Checklist
Release Notes