Use Tekton V1 API when working with TaskRuns #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
added
the
kind/feature
openshift-ci
bot
added
the
release-note
pull-request-size
bot
added
the
size/XL
SaschaSchwarze0
force-pushed
the
sascha-tekton-v1
branch
from
aedacd6
to
5bb47a6
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HeavyWombat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1434
This pull request changes our controller code to use the V1 API of Tekton to work with TaskRuns. This was mostly straight-forward.
I had to adjust the config package. There, we also used Tekton's
Steptype. I changed it to our own type to maintain API compatibility to supportresourceswhile Tekton moved tocomputeResourcesin V1.I also used the chance to use the same import everywhere,
pipelineapi "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1".Submitter Checklist
Release Notes