[release-v0.12] SHIP-0038: Run CI on Release Branches #1543
Conversation
Update our CI-oriented GitHub actions to run when commits merge in a `release-v*` branch, or a pull request is opened against a `release-v*` branch. With this change, future release branches will automatically have CI checks enabled. This commit should be backported to enable CI in a prior release branch. This implements a portion of SHIP-0038. Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
pull-request-size
bot
added
the
size/XS
openshift-ci
bot
added
release-note-none
|
gosec picked up a few items that should not block merge of this. Once this PR merges, I can set up the branch protection rules. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@adambkaplan @qu1queee Can we merge #1547 before? Should fix golangci-lint errors. |
This is done. @adambkaplanI am okay with either: you rebase and this PR gets fully green or we red-merge it. |
|
Doing the "red button" merge on this, so that I can then set up the branch protection rules. |
adambkaplan
merged commit f5fdcdf
into
shipwright-io:release-v0.12
Changes
Update our CI-oriented GitHub actions to run when commits merge in a
release-v*branch, or a pull request is opened against arelease-v*branch. With this change, future release branches will automatically have CI checks enabled. This commit should be backported to enable CI in a prior release branch.This implements a portion of SHIP-0038.
See also shipwright-io/community#85
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
/kind cleanup