Release Workflow Fixes #1565
Merged
Release Workflow Fixes #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes for the release workflow to support release branches: - Print input parameters at the start of the workflow. - Use input git reference for release. - Sign image using sha of the tag's git commit. Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
pull-request-size
bot
added
the
size/S
openshift-ci
bot
added
release-note-none
SaschaSchwarze0
requested changes
Apr 2, 2024
Comment on lines
+63
to
+64
| # TODO: This action is no longer mainained. We should use a different action | ||
| # or the gh command line directly. |
There was a problem hiding this comment.
Can you open an issue instead or in addition?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes for the release workflow to support release branches:
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes