Correct multiple secret values in one array parameter that references different secret variables

[SaschaSchwarze0]

Changes

There is a bug when defining the following Build:

spec:
  paramValues:
    name: param-name
    values:
    - secretValue:
        name: secret-name
        key: key-1
        format: ARG_NAME1=${SECRET_VALUE}
    - secretValue:
        name: secret-name
        key: key-2
        format: ARG_NAME2=${SECRET_VALUE}

Due to the way we iterate over the values, we caused the TaskRun to only have references to key-2. Unfortunatly, our existing unit test did not capture that. Also extending those.

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

Release Notes

The usage of different secrets or secret keys as values inside one array parameter is now possible

[qu1queee]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qu1queee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SaschaSchwarze0]

/cherrypick release-v0.13

[openshift-cherrypick-robot]

@SaschaSchwarze0: new pull request created: #1593

In response to this:

/cherrypick release-v0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.