Remove ruby samples for Buildpacks #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to our default CBS being Paketo, we should not have samples for ruby buildpacks. Paketo is not officially supporting this runtime yet, but there is a proposal already https://github.com/paketo-buildpacks/rfcs/blob/master/accepted/0005-ruby-promotion.md I would like to remove this from the repo for now, because it can lead to confusion. We can build the image for ruby, but during deployment times, this will not work due to missing dependencies. This could lead to bad experiences for the Build. I would bring this samples back once the gcr.io/paketo-buildpacks/builder:latest have support for Ruby buildpacks.
|
Hi! Paketo contributor here. I just ran into this issue. Just want to note that we should be picking up the issue to actually promote Ruby pretty soon (paketo-buildpacks/ruby#418), but it could take us a little longer to get it added into the builders, so this change makes sense. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to our default CBS being Paketo, we should not have samples
for ruby buildpacks. Paketo is not officially supporting this
runtime yet, but there is a proposal already https://github.com/paketo-buildpacks/rfcs/blob/master/accepted/0005-ruby-promotion.md
I would like to remove this from the repo for now, because it can lead to confusion. We can build
the image for ruby, but during deployment times, this will not work due to missing dependencies. This
could lead to bad experiences for the Build.
I would bring this samples back once the gcr.io/paketo-buildpacks/builder:latest have support
for Ruby buildpacks.