Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/go-git/go-git/v5 #758

Merged

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented May 4, 2021

Changes

This will provide us a context with a timeout when listing refs of
a remote repository. This helps on preventing calls to the outside
on hanging and leading to blockers in our Build reconcile space.

The bump is done against the this commit go-git/go-git@67d3490 , which @xiujuan95 was nice to open in that repo.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Bump github.com/go-git to support a ctx with timeout when listing

@openshift-ci-robot openshift-ci-robot added the release-note Label for when a PR has specified a release note label May 4, 2021
This will provide us a context with a timeout when listing refs of
a remote repository. This helps on preventing calls to the outside
on hanging and leading to blockers in our Build reconcile space.
@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label May 4, 2021
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit fe37e14 into shipwright-io:master May 4, 2021
@qu1queee qu1queee deleted the qu1queee/git_ctx_add branch May 4, 2021 15:32
@adambkaplan adambkaplan added this to the release-v0.5.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants