Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect statement about contextDir limitation #880

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Remove incorrect statement about contextDir limitation #880

merged 1 commit into from
Sep 29, 2021

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Since a while already, all our strategies support the contextDir. Buildah was the last one. Fixing this in the docs.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Correcting the statement about the contextDir which is supported in all sample build strategies

@SaschaSchwarze0 SaschaSchwarze0 added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 29, 2021
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Sep 29, 2021
@gabemontero
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7e38a4b into shipwright-io:main Sep 29, 2021
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-doc-context-dir branch September 29, 2021 12:16
@adambkaplan adambkaplan added this to the release-v0.6.0 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabemontero gabemontero Awaiting requested review from gabemontero

@qu1queee qu1queee Awaiting requested review from qu1queee

Assignees

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Milestone
release-v0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SaschaSchwarze0 @gabemontero @adambkaplan @openshift-merge-robot