Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish latest tag during nightly release / publish sample strategies #883

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Publish latest tag during nightly release / publish sample strategies #883

merged 1 commit into from
Oct 1, 2021

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Oct 1, 2021 •
edited

Changes

Fixes #801
Fixes #877

Some pipeline changes:

  • Create a sample-strategies.yaml in the release.sh script containing all cluster build strategies
  • Publish the sample-strategies.yaml in a release and nightly release
  • Using crane copy to create the latest tag for our images during the nightly build

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Nightly and normal releases now include a sample-strategies.yaml

@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 1, 2021
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Oct 1, 2021
gabemontero
gabemontero approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

.github/workflows/nightly.yaml Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 90633d4 into shipwright-io:main Oct 1, 2021
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-nightly-updates branch October 4, 2021 06:31
@adambkaplan adambkaplan added this to the release-v0.6.0 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabemontero gabemontero gabemontero approved these changes

@sbose78 sbose78 Awaiting requested review from sbose78

@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

Assignees

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Milestone
release-v0.6.0
Development

Successfully merging this pull request may close these issues.

Push latest tag of our images during nightly build Release v0.5.0 misses default_strategies.yaml
4 participants
@SaschaSchwarze0 @gabemontero @adambkaplan @openshift-merge-robot