Remove -sa suffix from generated service account #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
SaschaSchwarze0
force-pushed
the
sascha-remove-sa-suffix
branch
from
b5bd7f9
to
bfdeb63
Compare
SaschaSchwarze0
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
SaschaSchwarze0
added
do-not-merge/work-in-progress
HeavyWombat
approved these changes
Oct 6, 2021
Yes, I'll open one for v1.0.0. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HeavyWombat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There was a bug in Calico before 3.20.0 where it unconditionally passed
pod.spec.serviceAccountNameas a label value to its WorkloadEndpoint. But label values cannot exceed 63 characters while a longer ServiceAccount name is allowed. Their fix is Use a spec field on WEPs for ServiceAccount name #1422.But, especially in managed Kubernetes environments, the Calico version is not necessarily that new. For example, IKS 1.21 is at 3.19 just slightly below this.
In Shipwright, we already limit the BuildRun length to 63 characters because we use it as label value on the TaskRun (and pod). But, the name of the generated ServiceAccount used to be
${buildRunName}-sa.I changed the logic to make the name of the ServiceAccount be the BuildRun name. Added code to still delete the one with the
-sasuffix to not cause dangling SAs.Used that chance to move the removal logic from buildrun.go into serviceaccount.go.
Submitter Checklist
Release Notes