Updates go to v1.17

[sm43]

This patch does the following

• update go.mod and run go mod vendor
• update workflow
• update hack.md
• update the ko build strategy
• update the sample ko build that builds shipwright

Closes #942

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Changes

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Shipwright Build is now built with Go v1.17

[SaschaSchwarze0]

Hi @sm43, thank you for looking into this. Two minor change requests.

[SaschaSchwarze0]

@sm43 Regarding the failures in the verify step, I guess, it is time to replace the remaining go gets in the one or other shell script with go installs.

[sm43]

/kind dependency-change

[sm43]

@SaschaSchwarze0 Can you help me understand this tag?

build/pkg/apis/build/v1alpha1/zz_generated.deepcopy.go

Line 1 in 06cddcc

//go:build !ignore_autogenerated

with go v1.17 the tag is changed to //go:build !ignore_autogenerated previoulsy it was // +build !ignore_autogenerated

• this tag ignore the file when we do go build right?
• this tag is added by generate script so now do we need to keep both the tags or remove the older one? if we want to remove how do we do that as it is a generated file?

[SaschaSchwarze0]

@SaschaSchwarze0 Can you help me understand this tag?

build/pkg/apis/build/v1alpha1/zz_generated.deepcopy.go

Line 1 in 06cddcc

//go:build !ignore_autogenerated

with go v1.17 the tag is changed to //go:build !ignore_autogenerated previoulsy it was // +build !ignore_autogenerated

* this tag ignore the file when we do `go build` right?

* this tag is added by generate script so now do we need to keep both the tags or remove the older one? if we want to remove how do we do that as it is a generated file?

Based on the Go 1.17 release notes:

The go command now understands //go:build lines and prefers them over // +build lines.

I think having both is fine assuming it was generated like this.

[sm43]

@SaschaSchwarze0 Can you help me understand this tag?

build/pkg/apis/build/v1alpha1/zz_generated.deepcopy.go

Line 1 in 06cddcc

//go:build !ignore_autogenerated

with go v1.17 the tag is changed to //go:build !ignore_autogenerated previoulsy it was // +build !ignore_autogenerated

* this tag ignore the file when we do `go build` right?

* this tag is added by generate script so now do we need to keep both the tags or remove the older one? if we want to remove how do we do that as it is a generated file?

Based on the Go 1.17 release notes:

The go command now understands //go:build lines and prefers them over // +build lines.

I think having both is fine assuming it was generated like this.

yes it was generated like this. updated the pr. ptal

[SaschaSchwarze0]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SaschaSchwarze0]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment