Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tekton and Kubernetes dependencies #958

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Update Tekton and Kubernetes dependencies #958

merged 2 commits into from
Dec 9, 2021

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Dec 9, 2021 •
edited

Changes

Fixes #910

This was more invasive than expected. Basically there were signature changes in the Kubernetes interfaces that I had to adopt to.

The minimum Kubernetes version comes from Tekton 0.30. Was a little surprised that it does not support 1.19 anymore.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

action required: We updated our used Tekton and Kubernetes dependencies. The minimum Kubernetes version now is v1.20

@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Dec 9, 2021
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-action-required labels Dec 9, 2021
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-update-tekton-kubernetes branch 5 times, most recently from d3593dc to c33d6cd Compare December 9, 2021 09:46
@SaschaSchwarze0 SaschaSchwarze0 changed the title WIP: Update Tekton and Kubernetes dependencies Update Tekton and Kubernetes dependencies Dec 9, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2021
@gabemontero
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2021
@gabemontero
Copy link
Member

I saw all the doc updates I was expecting, and the k8s related signature updates are in line with what I recall from similar k8s bumps in other projects I work on.

That said, given the breadth of this change, let's get multiple eyes reviewing this one. I'll defer to @adambkaplan for taking a pass at this and being in charge of applying the lgtm if he is also good with it.

@gabemontero
Copy link
Member

/assign @adambkaplan
/assign @gabemontero

adambkaplan
adambkaplan approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0a590a6 into shipwright-io:main Dec 9, 2021
@adambkaplan
Copy link
Member

The minimum Kubernetes version comes from Tekton 0.30. Was a little surprised that it does not support 1.19 anymore.

Is this true? The current installation doc claims the min supported version is 1.19. See https://github.com/tektoncd/pipeline/blob/main/docs/install.md#before-you-begin.

@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-update-tekton-kubernetes branch December 9, 2021 19:47
@SaschaSchwarze0
Copy link
Member Author

The minimum Kubernetes version comes from Tekton 0.30. Was a little surprised that it does not support 1.19 anymore.

Is this true? The current installation doc claims the min supported version is 1.19. See https://github.com/tektoncd/pipeline/blob/main/docs/install.md#before-you-begin.

For reference here, as discussed in slack: caused by tektoncd/pipeline#4354 (review)

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.7.0 milestone Dec 9, 2021
@adambkaplan adambkaplan mentioned this pull request Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@gabemontero gabemontero Awaiting requested review from gabemontero

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@adambkaplan adambkaplan

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note-action-required
Projects
None yet
Milestone
release-v0.7.0
Development

Successfully merging this pull request may close these issues.

Update Tekton and Kubernetes dependencies
4 participants
@SaschaSchwarze0 @gabemontero @adambkaplan @openshift-merge-robot