Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIP-0038] Use Release Branches for Releasing #238

Closed
1 task done
adambkaplan opened this issue Mar 21, 2024 · 4 comments
Closed
1 task done

[SHIP-0038] Use Release Branches for Releasing #238

adambkaplan opened this issue Mar 21, 2024 · 4 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@adambkaplan
Copy link
Member

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.

Per SHIP-0038, we are changing our release process to ship official releases from a release branch, rather than from main.

Describe the solution that you would like.

  • CI and release scripts can be run on a release branch (with release-v* pattern)
  • Release workflows must use an appropriate release branch and/or git reference (cannot blindly use latest commit from main)
  • Tagging should be part of the release script process (currently must be done manually by a maintainer).

Describe alternatives you have considered.

See SHIP-0038 for discussion

Anything else?

Part of shipwright-io/community#85

@adambkaplan adambkaplan added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 21, 2024
@adambkaplan adambkaplan added this to the release-v0.13.0 milestone Mar 21, 2024
@qu1queee
Copy link
Contributor

qu1queee commented Apr 4, 2024

@adambkaplan how long does this issue needs to be open? what is missing?

@adambkaplan
Copy link
Member Author

I guess this is missing a definition of done - I recommend we close this when we are able to demonstrate that we can release the CLI via a respective release branch (v0.13 as candidate).

@adambkaplan
Copy link
Member Author

/close

Released v0.13.0 with the branching mechanism!

@openshift-ci openshift-ci bot closed this as completed May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

@adambkaplan: Closing this issue.

In response to this:

/close

Released v0.13.0 with the branching mechanism!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
Development

No branches or pull requests

2 participants