publish image nightly #50
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liangyuanpeng The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
liangyuanpeng
force-pushed
the
publish_image_nightly
branch
4 times, most recently
from
b4bc5ec
to
d4007c5
Compare
Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
force-pushed
the
publish_image_nightly
branch
from
d4007c5
to
610ccaf
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
|
||
| mv release.yaml nightly-${{ steps.date.outputs.date }}.yaml | ||
| mv release-debug.yaml nightly-${{ steps.date.outputs.date }}-debug.yaml | ||
| # gh release upload nightly nightly-${{ steps.date.outputs.date }}.yaml |
There was a problem hiding this comment.
Pending for a release of nightly.
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| name: shipwright-build |
There was a problem hiding this comment.
Necessary? when delete the release of triggers, it will be delete the namespace of shipwright-build.
like:
kubectl delete -f release-triggers.yaml
There was a problem hiding this comment.
The release yaml creation should be based on the helm chart that exists. It should not introduce new deployment artifacts. Basically like I started here: main...SaschaSchwarze0:shipwright-io-triggers:sascha-nightly. But we also want to publish the Helm chart itself to something like ArtifactHub which I had not yet time to look into.
So we will create a helm chart for triggers? I thought this was a mistake because we could deploy triggers from operator. 😅 And have not found Helm chart for shipwright build, So a question is just create alone Helm chart for triggers or have plan to work for all of component?
Publish the Helm chart to ghcr.io with oci would be great, ArtifactHub do not store something, it's just show something. Also can create a artifacthub repository for shipwright trigger after release helm chart for observability. |
Changes
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes