SHIP-0004: Build Environment Variables #53
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @adambkaplan @otaviof |
coreydaley
added
documentation
|
Documentation for shipwright-io/build#817 |
|
@coreydaley for API docs we write the doc in the repository with the code (shipwright-io/build in this case), and then sync the documentation to the website at release time. I did this manually the last time - we have a TODO to automate this in #29. |
| - name: EXAMPLE_VAR_1 | ||
| value: "example-value-1" | ||
| - name: EXAMPLE_VAR_2 | ||
| value: "example-value-2" |
There was a problem hiding this comment.
aside from the where you initially specify content comment from @adambkaplan - my comment in the shipwright-io/build PR about the type of this field would come into play
if this field is going to be k8s corev1.EnvVar, then we need more examples to show getting content from configmaps, secrets, etc.
or our doc cites those are not supported
if, however, we go with a a simpler type that is a subset of corev1.EnvVar, then these examples seem sufficient
There was a problem hiding this comment.
Moved documentation to shipwright-io/build#817
|
/close |
|
@coreydaley: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adding documentation for SHIP-0004: Build Environment Variables