Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null HttpClient #28

Closed
Shiroechi opened this issue Dec 16, 2020 · 1 comment · Fixed by #29
Closed

Null HttpClient #28

Shiroechi opened this issue Dec 16, 2020 · 1 comment · Fixed by #29
Assignees
Labels
bug Something isn't working

Comments

@Shiroechi
Copy link
Owner

BooruDex/Booru/Booru.cs

Lines 258 to 260 in c89b2ff

using (var request = new HttpRequestMessage(HttpMethod.Get, url))
using (var response = await this._HttpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead))
using (var stream = await response.Content.ReadAsStreamAsync())

BooruDex/Booru/Booru.cs

Lines 309 to 311 in c89b2ff

using (var request = new HttpRequestMessage(HttpMethod.Get, url))
using (var response = await this._HttpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead))
using (var stream = await response.Content.ReadAsStreamAsync())

When creating client with null HttpClient it not called the lazy option.

@Shiroechi Shiroechi added the bug Something isn't working label Dec 16, 2020
@Shiroechi Shiroechi self-assigned this Dec 16, 2020
@Shiroechi Shiroechi linked a pull request Dec 16, 2020 that will close this issue
4 tasks
@Shiroechi Shiroechi mentioned this issue Dec 16, 2020
4 tasks
@Shiroechi
Copy link
Owner Author

Fixed in PR #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant