Skip Scm_SortMethods if we have only one applicable method

shirok · Apr 24, 2017 · 556fee9 · 556fee9
1 parent a45cb3a
commit 556fee9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -1,5 +1,8 @@
 2017-04-23  Shiro Kawai  <shiro@acm.org>
 
+	* src/vmcall.c: Skip Scm_SortMethods when we have only one applicable
+	  methods.  Obvious, yeah?  This makes 'ref' call 20% faster.
+
 	* src/libproc.scm (method-leaf?): Added.
 	* src/class.c: Changed <method> slot name: method-leaf -> leaf?
 	* src/libobj.scm: Dropped %method-code, for we already have

diff --git a/src/vmcall.c b/src/vmcall.c
@@ -274,7 +274,9 @@
                 for (int i=0;i<argc; i++, ap++) SCM_FLONUM_ENSURE_MEM(*ap);
             }
 #endif /*GAUCHE_FFX*/
-            mm = Scm_SortMethods(mm, ARGP, argc);
+            if (SCM_PAIRP(SCM_CDR(mm))) {
+                mm = Scm_SortMethods(mm, ARGP, argc);
+            }
             if (SCM_METHOD_LEAF_P(SCM_CAR(mm))) {
                 nm = SCM_TRUE;  /* Dummy */
             } else {