Start using C99 #23
Merged
Start using C99 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we discussed, it's probably time to allow C99 features, especially mixing declarations and code, in Gauche souce code. Using C99 allows us to write more readable code. I think that MSVC is the only major C compiler that does not support C99, but because (1) we are using MinGW for Windows support, and (2) MSVC 2013 started supporting most C99 features, I'd think that wouldn't block us from migrating to C99. Compiler may need -std=c99 or -std=gnu99 to turn on C99 support. AC_PROG_CC_STDC will do that for you if you have autoconf 2.69 or later. We already have the macro call in configure.ac. This patch is to convert list.c to C99 as a starter. If it looks good, I'll do the same thing on other files too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed, it's probably time to allow C99 features, especially mixing
declarations and code, in Gauche souce code. Using C99 allows us to write more
readable code.
I think that MSVC is the only major C compiler that does not support C99,
but because (1) we are using MinGW for Windows support, and (2) MSVC 2013
started supporting most C99 features, I'd think that wouldn't block us from
migrating to C99.
Compiler may need -std=c99 or -std=gnu99 to turn on C99 support.
AC_PROG_CC_STDC will do that for you if you have autoconf 2.69 or later. We
already have the macro call in configure.ac.
This patch is to convert list.c to C99 as a starter. If it looks good, I'll do
the same thing on other files too.