Implement better CI checks #734
Comments
|
sorry for not say that but yesterday I have enabled that setting.
or, if you are familiar with Gitlab CI, it is fine to migrate to it for me. |
|
Thanks for setting this. We will see next time a PR is created. We could have both Gitlab and Circle CIs by the way. I'm leaving this issue open for the GitlabCI part. |
|
I confirm CircleCI ran tests in #735, excellent! 👏. For the GitlabCI part, I now remember I won't be able to add it if I'm not Owner of the repo unfortunately. |
|
I think these checks are sufficient for now, it already checks that it compiles on all platforms. I will probably implement a go-fmt check though and will close this afterwards. |
|
Test https://staticcheck.io/docs/ also maybe |
|
https://cirrus-ci.org/features/
To be tested. I'm also curious about builds.sr.ht, which has 1st class support for various BSDs https://man.sr.ht/tutorials/builds.sr.ht/github-integration.md |
Linked to #733
We currently use CircleCI for gopsutil CI. As far as I can see it doesn't run for our PRs, it looks like we should enable this option which is disabled by default
https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories
We should maybe also contact CircleCI to have macOS builders (see here) for free.
As I'm not even admin of the github repo I won't be able to do this, could you @shirou?
I'm also thinking about using Gitlab CI as I'm very familiar with it at work (as I administrate our own self-hosted Gitlab and runners), using their hosted instance at gitlab.com. We could even use our own runners on more platforms than what is proposed for free by CircleCI.
The text was updated successfully, but these errors were encountered: