New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit #209
Add pre-commit #209
Conversation
I was wrong, somebody with more permissions in the organization would need to allow the App to access this repo: https://github.com/marketplace/pre-commit-ci |
I think only @mrshirts can do that! |
Did I manage to activate it correctly? |
5a4cb0e
to
f30856a
Compare
Probably - although I think it's likely the bot won't run until the config file exists on the default branch (i.e. until this is merged). So I didn't give sufficient instructions when asking for help, sorry! @ptmerz would you consider reviewing this as-is? The changes to the source code are only because of black's recent update. You're probably familiar with git hooks but you could verifiy things locally with i.e.
Depending on interest and effort there's plenty more cool stuff that can be done. But my goal here was only to update with the new version of black and set up automation so that a bot would do it the next time there's an update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you @mattwthompson. I played around a bit locally, happy to approve!
A bot from https://pre-commit.ci should run in and automatically run
black
with its most recent version