Update Project Structure to MolSSI CMS Template #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds GitHub Actions workflows for automated CI and linting, and the required helper scripts (devtools). * Adds GitHub PR and contributing templates. * Adds pytest to the repo, and adds a simple root test. * Adds versioneer * Updates setup scripts to follow the recommended CMS template. * Adds useful setup settings (Mostly from the CMS template). * Adds codecov settings (from the CMS template)
mattwthompson
previously approved these changes
Apr 24, 2020
There was a problem hiding this comment.
LGTM skimming through it
Re: the lack of unit tests, is there enough code here that falls in the scope of unit tests? Or are the tests more high-level than that? I'm not familiar enough with this package to understand the testing that's needed to ensure it's working
Closed
ptmerz
approved these changes
Apr 28, 2020
|
Also, we will want to document the CI somewhat, but that shouldn't block this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR copies over most of the missing files from the MolSSI CMS cookiecutter template.
This largely includes:
setup.cfg.Note:
versioneer.pyscript does not need to be reviewed as it simply the standard script which ships from versioneer.linttest is expected to fail as the code has not yet been linted, this will be handled in a separate PR.Status