Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom styles for auto-generated divs with animations #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sebight
Copy link

@Sebight Sebight commented Aug 6, 2022

I used this library in my project, but had problems with implementing it with my current structure.

I've written myself a small tweak, which allowed me to apply custom styles to the automatically generated. It is simply sent as a prop and then applied in the component.

This can come in handy in many cases and does not change the original functionality of the library.

@shiryel
Copy link
Owner

shiryel commented Aug 15, 2022

Hi Sebight, I appreciate the PR, but I would like to know if it were not possible to use the css_observer and the css_animation external variables to accomplish the same result. Their initial objective were to customize the styles by the parent, they are not used internally by the lib in any other way.

@Sebight
Copy link
Author

Sebight commented Aug 18, 2022

Oof. Haven't actually noticed that.

That might be enough though, yes. But if you ever find this modification handy, feel free to merge it! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants