-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guess tags by file name #515
Comments
As far as I know there's no way to see the filename before the upload is complete; but if there is a way, this would be nice. Maaaybe the AJAX upload APIs have something? That would require replacing the whole upload process with an AJAX-based one, but that might actually make things a lot nicer (eg, start uploading the file as soon as it's selected, show the thumbnail alongside the enter-tags box) (We could do the initial upload, and then show a second screen with "you've just uploaded this image, would you also like to add these tags to the image", but that seems messy both from a user and code standpoint) |
Not really. Async upload and thumbnail generation is easy to implement since we have libraries like https://blueimp.github.io/jQuery-File-Upload/ + something like Symfony's Request http://symfony.com/doc/current/components/http_foundation/introduction.html |
is there a way to create an extension for doing this? if so, i would create one. |
jQuery-file-upload looks wonderful -- If it can fall back to regular file uploads for people with no JS, it'd be great to improve the standard upload extension; if it needs to be very different, it should be possible to copy-paste ext/upload to ext/upload-js and work from there |
Just my humble opinion: |
Not many people, but enough that whenever I accidentally break a no-JS fallback method it's rarely more than a day before I get complaints >_< Personally unless it's really easy to integrate both methods, I think I would just keep the existing upload as is, add the awesome new uploader alongside it, and then use modernizr's .js / .no-js CSS classes to decide which one to display.
how about only adding tags which other images have already used? |
That's a great idea, it would work I think. |
That sounds like a useful setting that should come turned on by default. |
@lisandro52 agree |
I would love to use the filename as a tag, even if i hasn't been used in other files on my personal shimmie, as my image names are dates and time the photo was taken. |
@dali99 that's why there must be an option for being able to use custom regexp |
This should probably be added to the bulk uploader as well. |
A bit late to conversation, but I have a few thoughts to add to this. Somewhat expanding on what @cyb-er said, another thing to think about when suggesting tags is what if the tag looks valid, but is a tag for something else entirely? @JarJak: Problem with anything user-defined is there isn't really a place to set it, same goes to allowing the user to disable the feature entirely. As for multi-upload, I'm fairly sure that already exists in some form on the actual /upload page. Probably doesn't help that only the lite & danbooru themes link to it though :\ |
How about just putting additional JS layer on top of actual multi upload? It will replace regular mutli file form with its own form, but will send files and tags as regular form does and of course it will be no-JS compatible. So there would be no need to override DataUploadEvent, just pure JS. |
I know this comment is very late. I can't seem to see if your looking for a JavaScript or PHP solution. Let me know and I can provide a solution for either. |
when i upload file like funny_cat_photo.jpg i would like to get #funny #cat #photo tags to be suggested by default
The text was updated successfully, but these errors were encountered: