Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev synctask #3

Merged
merged 7 commits into from
Oct 1, 2022
Merged

Dev synctask #3

merged 7 commits into from
Oct 1, 2022

Conversation

awidesky
Copy link
Contributor

@awidesky awidesky commented Oct 1, 2022

#2
this branch includes a bugfix in readme + tiny enhancement for readability.
Added Synchronized versions of JMailTM.delete(), Attachment.save(), Message.markAsRead() methods.

Little problem is that I'm not available to test the code.
it seems like maven build option in eclipse does not bundle all dependencies.
tried building in intelij, but not worked as well.
maybe I made some mistake because I'm still new to maven. wanna know how you do build it :)

Domains.getRandomDomain() returns an Domain object.
It does not override toString(), so
"thisismychoice@"+Domains.getRandomDomain() will be like
thisismychoice@me.shivzee.util.Domain@7fb4f2a9
This cause following Exception :
javax.security.auth.login.LoginException: Something went wrong while
creating account! Try Againjavax.security.auth.login.LoginException:
Account Already Exists! Error 422
	at me.shivzee.util.JMailBuilder.createAndLogin(JMailBuilder.java:94)

To fix this, I called getDomainName() to get real domain name, and it
worked fine. :)
Sorry, since I'm in army, all  I can use in here is just Eclipse
Portable XD
@shivam1608 shivam1608 merged commit 47b5b3b into shivam1608:main Oct 1, 2022
@shivam1608
Copy link
Owner

Thank you for your outstanding work @awidesky 😀

@awidesky awidesky deleted the dev-synctask branch October 1, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants