-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installing a specific Composer version #321
Allow installing a specific Composer version #321
Conversation
This script is successful for me: npm ci
npm run format-check |
7462f34
to
3f5cf2d
Compare
Whoops, I forgot to push the changes... see the force push |
It seems that the automatic creation of |
3f5cf2d
to
f51d00d
Compare
In order to fix that I had to run git config core.autocrlf true |
About this check:
How can I test it? What about adding a note about that in https://github.com/shivammathur/setup-php/blob/master/.github/CONTRIBUTING.md ? |
I managed to answer myself:
For example, to test this PR, I used steps:
- name: Setup PHP
uses: mlocati/setup-php@composer-specific-version
with:
php-version: "7.2"
coverage: none
tools: composer:v1.7.2
|
@mlocati Sorry for a bit of a delay, I have merged this and refactored a bit of it. - name: Setup PHP
uses: shivammathur/setup-php@develop
with:
php-version: '7.2'
tools: 'composer:1.7.2' I will update |
I wouldn't call that a delay, you are super fast! 😉 |
name: ⚙ Improvement
about: What about letting users specify a specific Composer version
labels: enhancement
Description
This PR let users specify a specific Composer version. This is useful in particular to test Composer plugins which should support old Composer versions.
npm run format
before the commit.npm run lint
before the commit.npm run release
before the commit.npm test
returns with no unit test errors and all code covered.