Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document php-version can come from platform overrides in composer.lock or composer.json #800

Merged
merged 2 commits into from Dec 8, 2023

Conversation

davereid
Copy link
Contributor

@davereid davereid commented Dec 7, 2023


name: ⚙ Improvement
about: Add documentation that php-version can come from the platform override version set in composer.lock or composer.json
labels: enhancement


A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions,
so that the development can be pointed in the intended direction.

Related discussion: None

Further notes in Contribution Guidelines
Thank you for your contribution.

Description

This PR documents the behavior in the readPHPVersion() method in utils.js

In case this PR introduced TypeScript/JavaScript code changes:

  • [na] I have written test cases for the changes in this pull request
  • [na] I have run npm run format before the commit.
  • [na] I have run npm run lint before the commit.
  • [na] I have run npm run release before the commit.
  • [na] npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • [na] I have checked the edited scripts for syntax.
  • [na] I have tested the changes in an integration test (If yes, provide workflow YAML and link).

@davereid davereid marked this pull request as ready for review December 7, 2023 16:56
@shivammathur shivammathur merged commit 9e24ffa into shivammathur:develop Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants