Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for replying to messages in Message box #153

Closed
kuv2707 opened this issue Jun 23, 2024 · 4 comments
Closed

Add support for replying to messages in Message box #153

kuv2707 opened this issue Jun 23, 2024 · 4 comments

Comments

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 23, 2024

Description

We need to add a way to select a message to be replied. The design is subject to discussion.
The implementation is mostly there:

  • The ChatMessage type has a field ref which stores the id of the message the current message is referring to.

Possible design

Perhaps we can make it so that clicking on a message selects it for replying, and when sending the message, we include the selected message's id in the ref field.
When displaying a message, we can take the content of the message ref is pointing to, and truncate it to around 20 characters, and display it in a dark css filter before the actual message content.

Copy link

Comment '@csoc-bot claim' to get this issue assigned or '@csoc-bot abandon' to get this issue unassigned.

@kuv2707
Copy link
Collaborator Author

kuv2707 commented Jun 23, 2024

@shivansh-bhatnagar18 Please take care of the design and UX that should be there for this.

@ritwik-69
Copy link
Contributor

@csoc-bot claim

Copy link

@ritwik-69 This issue has been successfully assigned to you! 🚀

ritwik-69 added a commit to ritwik-69/multiplayer-uno that referenced this issue Jun 24, 2024
This commit lets you reply to others in chat during game.

fixes shivansh-bhatnagar18#153
ritwik-69 added a commit to ritwik-69/multiplayer-uno that referenced this issue Jun 24, 2024
This commit lets you reply to others in chat during game.

fixes shivansh-bhatnagar18#153
ritwik-69 added a commit to ritwik-69/multiplayer-uno that referenced this issue Jun 25, 2024
This commit lets you reply to others in chat during game.

fixes shivansh-bhatnagar18#153
ritwik-69 added a commit to ritwik-69/multiplayer-uno that referenced this issue Jun 25, 2024
This commit lets you reply to others in chat during game.

fixes shivansh-bhatnagar18#153
ritwik-69 added a commit to ritwik-69/multiplayer-uno that referenced this issue Jun 25, 2024
This commit lets you reply to others in chat during game.

fixes shivansh-bhatnagar18#153
ritwik-69 added a commit to ritwik-69/multiplayer-uno that referenced this issue Jun 26, 2024
This commit lets you reply to others in chat during game.

fixes shivansh-bhatnagar18#153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants