This repository has been archived by the owner on Sep 29, 2022. It is now read-only.
Updates from upstream #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting
* Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc
shiweing
added a commit
that referenced
this pull request
Oct 25, 2019
) * Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Update sequence diagram for filter note implementation (cherry picked from commit 8a5cdcb)
shiweing
added a commit
that referenced
this pull request
Oct 29, 2019
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Add DeleteNoteParserTest * Add parse delete test for NoteCommandParserTest * Add NoteParserUtilTEst for parsing note id * Fix checkstyle * Fix checkstyle
shiweing
added a commit
that referenced
this pull request
Oct 29, 2019
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Change EditNoteCommand to use Model#findNote() * Implement successful execution test for edit note command * Add edit command test for partial edit * Add negative test for no input to edit note command * Add invalid note id test for edit note * Add test fro EditNoteCommand#equals() * Fix checkstyle * Add EditNoteParserTest * Fix checkstyle * Fix checkstyle * Fix merge error
shiweing
added a commit
that referenced
this pull request
Oct 31, 2019
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add ClearNoteCommand * Add authorship
shiweing
added a commit
that referenced
this pull request
Nov 4, 2019
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Implement validation for multiple usage of prefix, change note to require either title or content * Change Note to be invalid only when both Title and Content empty * Fix checkstyle * Add length validation for Title * Implement Title validation in note commands
Merged
shiweing
added a commit
that referenced
this pull request
Nov 5, 2019
…-3#223) * Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add ability to create notes with tags * Add tag to note tests * Add testing for tags in CreateNoteParserTest * Fix test errors * Fix checkstyle * Fix checkstyle
shiweing
added a commit
that referenced
this pull request
Nov 7, 2019
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Update sample data (cherry picked from commit 990fa83d2b72578a4e4a34a52bbeb45a5d6320f3)
shiweing
added a commit
that referenced
this pull request
Nov 7, 2019
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add detailed example for note create, delete, edit in UG * Add detail example for note list, clear in UG * Set image width to 600 * Add images for UG * Fix some bugs in UG * Add comment on deleted note id
shiweing
added a commit
that referenced
this pull request
Nov 9, 2019
…S1-CS2103T-F12-3#234) * Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add detailed example for note create, delete, edit in UG * Add detail example for note list, clear in UG * Set image width to 600 * Add images for UG * Fix some bugs in UG * Add comment on deleted note id * Update note filter in DG * Show all notes after deleting * Fix test error * Fix test error * Fix checkstyle
shiweing
added a commit
that referenced
this pull request
Nov 10, 2019
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add detailed example for note create, delete, edit in UG * Add detail example for note list, clear in UG * Set image width to 600 * Add images for UG * Fix some bugs in UG * Add comment on deleted note id * Update note filter in DG * Show all notes after deleting * Fix test error * Fix test error * Fix checkstyle * Add PPP
shiweing
added a commit
that referenced
this pull request
Nov 11, 2019
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add detailed example for note create, delete, edit in UG * Add detail example for note list, clear in UG * Set image width to 600 * Add images for UG * Fix some bugs in UG * Add comment on deleted note id * Update note filter in DG * Show all notes after deleting * Fix test error * Fix test error * Fix checkstyle * Add PPP * Fix PPP * Udate PPP * Fix link in PPP
shiweing
added a commit
that referenced
this pull request
Nov 11, 2019
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add detailed example for note create, delete, edit in UG * Add detail example for note list, clear in UG * Set image width to 600 * Add images for UG * Fix some bugs in UG * Add comment on deleted note id * Update note filter in DG * Show all notes after deleting * Fix test error * Fix test error * Fix checkstyle * Add PPP * Fix PPP * Udate PPP * Fix link in PPP * Add legend to PPP * Add manual tests for notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.